[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c |
|
Date: |
Sun, 28 Mar 2021 10:40:45 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 3/26/21 1:36 PM, Claudio Fontana wrote:
+#ifdef CONFIG_TCG
+ arm_rebuild_hflags(env);
+#endif /* CONFIG_TCG */
No functional changes during code movement.
Really.
I cannot emphasize this enough.
Also, why is this an ifdef and not tcg_enabled()?
+ aarch64_restore_sp(env, new_el);
+#ifdef CONFIG_TCG
+ arm_rebuild_hflags(env);
+#endif /* CONFIG_TCG */
Likewise.
+#ifdef CONFIG_TCG
+ if (tcg_enabled()) {
Likewise. And, why in the world do you need both?
r~
- Re: [RFC v12 24/65] target/arm: move arm_sctlr away from tcg helpers, (continued)
- [RFC v12 28/65] target/arm: fixup sve_exception_el code style before move, Claudio Fontana, 2021/03/26
- [RFC v12 23/65] target/arm: move sve_zcr_len_for_el to common_cpu, Claudio Fontana, 2021/03/26
- [RFC v12 25/65] target/arm: move arm_cpu_list to common_cpu, Claudio Fontana, 2021/03/26
- [RFC v12 30/65] target/arm: fix style of arm_cpu_do_interrupt functions before move, Claudio Fontana, 2021/03/26
- [RFC v12 26/65] target/arm: move aarch64_sync_32_to_64 (and vv) to cpu code, Claudio Fontana, 2021/03/26
- [RFC v12 29/65] target/arm: move sve_exception_el out of TCG helpers, Claudio Fontana, 2021/03/26
- [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c, Claudio Fontana, 2021/03/26
- Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c,
Richard Henderson <=
- [RFC v12 32/65] target/arm: move TCGCPUOps to tcg/tcg-cpu.c, Claudio Fontana, 2021/03/26
- [RFC v12 38/65] target/arm: remove broad "else" statements when checking accels, Claudio Fontana, 2021/03/26
- [RFC v12 35/65] target/arm: remove kvm include file for PSCI and arm-powerctl, Claudio Fontana, 2021/03/26
- [RFC v12 39/65] target/arm: remove kvm-stub.c, Claudio Fontana, 2021/03/26
- [RFC v12 40/65] tests/qtest: skip bios-tables-test test_acpi_oem_fields_virt for KVM, Claudio Fontana, 2021/03/26