Re: [RFC v11 47/55] target/arm: make is_aa64 and arm_el_is_aa64 a macro for !TARGET_AARCH64

[Richard Henderson]

On 3/26/21 1:05 PM, Claudio Fontana wrote:
> On 3/25/21 8:03 PM, Richard Henderson wrote:
> > On 3/23/21 9:46 AM, Claudio Fontana wrote:
> > > +#define is_a64(env) (false)
> > ...
> > > +#define arm_el_is_aa64(env, el) (false)
> >
> > Why a define and not have the ifdef inside the static inline?
> >
> > This define is causing you to make other random changes to avoid unused
> > variables, and I'm not keen.
> >
> > If you're running into problems with --enable-debug not eliminating code
> > blocks, leading to link errors, then I think that
> > __attribute__((always_inline)) and a comment will be the best option.
>
> I am not getting linking troubles even with --enable-debug atm,
> so I'd avoid the attribute for now?

Then you must use the macro arguments in the define.

#define foo(x, y)  ((void)(x), (void)(y), false)


r~