Re: [PATCH v3 3/7] ui/vdagent: add mouse support

[Markus Armbruster]

Gerd Hoffmann <kraxel@redhat.com> writes:

> This patch adds support for mouse messages to the vdagent
> implementation.  This can be enabled/disabled using the new
> 'mouse' parameter for the vdagent chardev.  Default is on.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
[...]
> diff --git a/qapi/char.json b/qapi/char.json
> index 6e565ce42753..586ef2137368 100644
> --- a/qapi/char.json
> +++ b/qapi/char.json
> @@ -395,10 +395,12 @@
>  #
>  # Configuration info for vdagent.
>  #
> +# @mouse: enable/disable mouse, default is enabled.
> +#
>  # Since: 6.0
>  ##
>  { 'struct': 'ChardevVDAgent',
> -  'data': { },
> +  'data': { '*mouse'    : 'bool' },
>    'base': 'ChardevCommon' }
>  
>  ##

Ah, now ChardevVDAgent isn't the same as ChardevCommon anymore.

Please format like

     'data': { '*mouse': 'bool' },

for consistency with the rest of the file.

Acked-by: Markus Armbruster <armbru@redhat.com>