qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v11 28/55] target/arm: refactor exception and cpu code


From: Richard Henderson
Subject: Re: [RFC v11 28/55] target/arm: refactor exception and cpu code
Date: Thu, 25 Mar 2021 12:43:18 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 3/25/21 5:59 AM, Claudio Fontana wrote:
Isn't tcg/tcg-* redundant?

I considered that, and at some point I had "cpu.c" for x86 too. After working 
on it for a while, I noticed how
it got really confusing in practice to have files called just "cpu.c" when working on 
them, just too many files are called "cpu.c". It was confusing.

I also like the extra emphasis on the accel for this:

kvm/kvm.c
kvm/kvm-cpu.c
kvm/kvm-stub.c

tcg/tcg-cpu.c
tcg/tcg-stub.c

But then you go and invent

cpu-sve.c
kvm/cpu-sve.c
tcg/cpu-sve.c

etc.  So, please make up your mind.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]