Re: [PATCH v4 17/19] qapi/expr.py: Use tuples instead of lists for stati

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 17/19] qapi/expr.py: Use tuples instead of lists for stati

From:	Markus Armbruster
Subject:	Re: [PATCH v4 17/19] qapi/expr.py: Use tuples instead of lists for static data
Date:	Thu, 25 Mar 2021 16:19:32 +0100
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

John Snow <jsnow@redhat.com> writes:

> It is -- maybe -- possibly -- three nanoseconds faster.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>
>
> ---
>
> This can be dropped if desired; it has no real functional impact I could
> defend in code review court. I just happened to write it this way.

I'm fine with taking this.  Could it go right after PATCH 11?  If not,
no big deal.

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member, (continued)
- [PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases, John Snow, 2021/03/25
  - Re: [PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases, Markus Armbruster, 2021/03/25
    - Re: [PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases, John Snow, 2021/03/25
- [PATCH v4 12/19] qapi/expr.py: add type hint annotations, John Snow, 2021/03/25
- [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if, John Snow, 2021/03/25
  - Re: [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if, Markus Armbruster, 2021/03/25
    - Re: [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if, John Snow, 2021/03/25
- [PATCH v4 15/19] qapi/expr.py: enable pylint checks, John Snow, 2021/03/25
- [PATCH v4 17/19] qapi/expr.py: Use tuples instead of lists for static data, John Snow, 2021/03/25
  - Re: [PATCH v4 17/19] qapi/expr.py: Use tuples instead of lists for static data, Markus Armbruster <=
- [PATCH v4 16/19] qapi/expr.py: Add docstrings, John Snow, 2021/03/25
- [PATCH v4 18/19] qapi/expr.py: move related checks inside check_xxx functions, John Snow, 2021/03/25
- [PATCH v4 14/19] qapi/expr.py: Remove single-letter variable, John Snow, 2021/03/25
- [PATCH v4 11/19] qapi/expr.py: Modify check_keys to accept any Collection, John Snow, 2021/03/25
  - Re: [PATCH v4 11/19] qapi/expr.py: Modify check_keys to accept any Collection, Markus Armbruster, 2021/03/25
    - Re: [PATCH v4 11/19] qapi/expr.py: Modify check_keys to accept any Collection, John Snow, 2021/03/25
- [PATCH v4 19/19] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2021/03/25
- Re: [PATCH v4 00/19] qapi: static typing conversion, pt3, Markus Armbruster, 2021/03/25
- Re: [PATCH v4 00/19] qapi: static typing conversion, pt3, John Snow, 2021/03/25
- Re: [PATCH v4 00/19] qapi: static typing conversion, pt3, John Snow, 2021/03/26

Prev by Date: Re: [PATCH 0/1] iotests: fix 051.out expected output after error
Next by Date: Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings
Previous by thread: [PATCH v4 17/19] qapi/expr.py: Use tuples instead of lists for static data
Next by thread: [PATCH v4 16/19] qapi/expr.py: Add docstrings
Index(es):
- Date
- Thread