[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/15] Hexagon (target/hexagon) change variables from int to
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 05/15] Hexagon (target/hexagon) change variables from int to bool when appropriate |
|
Date: |
Thu, 25 Mar 2021 10:35:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
Hi Taylor,
On 3/25/21 3:50 AM, Taylor Simpson wrote:
> Address feedback from Richard Henderson <richard.henderson@linaro.org>
If you look at the git history, we use the following tags:
- Reported-by: Richard Henderson <richard.henderson@linaro.org>
- Suggested-by: Richard Henderson <richard.henderson@linaro.org>
and tools know how to use them:
https://repo.or.cz/git-dm.git/blob/5ccc4dac6837:/gitdm#l292
(same comment applies to other patches in your series).
That said,
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> target/hexagon/cpu_bits.h | 2 +-
> target/hexagon/decode.c | 80
> +++++++++++++++++++++++-----------------------
> target/hexagon/insn.h | 21 ++++++------
> target/hexagon/op_helper.c | 8 ++---
> target/hexagon/translate.c | 6 ++--
> target/hexagon/translate.h | 2 +-
> 6 files changed, 60 insertions(+), 59 deletions(-)
- [PATCH 04/15] Hexagon (target/hexagon) decide if pred has been written at TCG gen time, (continued)
- [PATCH 04/15] Hexagon (target/hexagon) decide if pred has been written at TCG gen time, Taylor Simpson, 2021/03/24
- [PATCH 08/15] Hexagon (target/hexagon) replace float32_mul_pow2 with float32_scalbn, Taylor Simpson, 2021/03/24
- [PATCH 09/15] Hexagon (target/hexagon) use softfloat for float-to-int conversions, Taylor Simpson, 2021/03/24
- [PATCH 06/15] Hexagon (target/hexagon) utility function changes, Taylor Simpson, 2021/03/24
- [PATCH 05/15] Hexagon (target/hexagon) change variables from int to bool when appropriate, Taylor Simpson, 2021/03/24
- [PATCH 02/15] Hexagon (target/hexagon) remove unnecessary inline directives, Taylor Simpson, 2021/03/24
- [PATCH 11/15] Hexagon (target/hexagon) circular addressing, Taylor Simpson, 2021/03/24
- [PATCH 15/15] Hexagon (target/hexagon) CABAC decode bin, Taylor Simpson, 2021/03/24
- [PATCH 13/15] Hexagon (target/hexagon) load and unpack bytes instructions, Taylor Simpson, 2021/03/24
- [PATCH 12/15] Hexagon (target/hexagon) bit reverse (brev) addressing, Taylor Simpson, 2021/03/24