Re: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)

[no-reply]

Patchew URL: 
20210323165308.15244-1-alex.bennee@linaro.org/">https://patchew.org/QEMU/20210323165308.15244-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210323165308.15244-1-alex.bennee@linaro.org
Subject: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, 
semihosting, testing)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210323094025.3569441-1-armbru@redhat.com -> 
patchew/20210323094025.3569441-1-armbru@redhat.com
 - [tag update]      patchew/20210323130614.146399-1-pbonzini@redhat.com -> 
patchew/20210323130614.146399-1-pbonzini@redhat.com
 * [new tag]         patchew/20210323165308.15244-1-alex.bennee@linaro.org -> 
patchew/20210323165308.15244-1-alex.bennee@linaro.org
Switched to a new branch 'test'
bcc7547 gitlab: default to not building the documentation
38b6266 iotests: iothreads need ioeventfd
7d603bd iotests: test m68k with the virt machine
175b36e iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"
c1434e3 blockdev: with -drive if=virtio, use generic virtio-blk
d9a5d5d m68k: add the virtio devices aliases
c077a9b qdev: define list of archs with virtio-pci or virtio-ccw
fe1df61 gitlab: extend timeouts for CFI builds
90e13f7 utils: Work around mingw strto*l bug with 0x
185f381 utils: Tighter tests for qemu_strtosz
d5854c3 cirrus.yml: Update the FreeBSD task to version 12.2
22b3df6 configure: Don't use the __atomic_*_16 functions for testing 128-bit 
support
527d4ef gitlab-ci.yml: Merge the trace-backend testing into other jobs
25e535d tests/tcg: add HeapInfo checking to semihosting test
fec9305 linux-user/riscv: initialise the TaskState heap/stack info
bdc3001 semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
a1a5d52 semihosting/arm-compat-semi: unify GET/SET_ARG helpers
0270290 semihosting: move semihosting tests to multiarch
a5310d0 tools/virtiofsd: include --socket-group in help
cecadd6 docs/devel: expand style section of memory management
2494a85 docs/devel: include the plugin API information from the headers
0967712 scripts/kernel-doc: strip QEMU_ from function definitions

=== OUTPUT BEGIN ===
1/22 Checking commit 0967712253a3 (scripts/kernel-doc: strip QEMU_ from 
function definitions)
2/22 Checking commit 2494a8533c43 (docs/devel: include the plugin API 
information from the headers)
3/22 Checking commit cecadd684571 (docs/devel: expand style section of memory 
management)
4/22 Checking commit a5310d05fd4b (tools/virtiofsd: include --socket-group in 
help)
5/22 Checking commit 0270290bfb74 (semihosting: move semihosting tests to 
multiarch)
6/22 Checking commit a1a5d52d3a8e (semihosting/arm-compat-semi: unify 
GET/SET_ARG helpers)
7/22 Checking commit bdc30013e582 (semihosting/arm-compat-semi: don't use 
SET_ARG to report SYS_HEAPINFO)
8/22 Checking commit fec930576473 (linux-user/riscv: initialise the TaskState 
heap/stack info)
9/22 Checking commit 25e535d4c651 (tests/tcg: add HeapInfo checking to 
semihosting test)
10/22 Checking commit 527d4eff0f98 (gitlab-ci.yml: Merge the trace-backend 
testing into other jobs)
11/22 Checking commit 22b3df69b30c (configure: Don't use the __atomic_*_16 
functions for testing 128-bit support)
12/22 Checking commit d5854c333694 (cirrus.yml: Update the FreeBSD task to 
version 12.2)
13/22 Checking commit 185f381817cd (utils: Tighter tests for qemu_strtosz)
14/22 Checking commit 90e13f730562 (utils: Work around mingw strto*l bug with 
0x)
ERROR: consider using qemu_strtol in preference to strtol
#145: FILE: util/cutils.c:409:
+        if (strtol(nptr, &tmp, 10) == 0 && errno == 0 &&

total: 1 errors, 0 warnings, 169 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/22 Checking commit fe1df614ddcc (gitlab: extend timeouts for CFI builds)
16/22 Checking commit c077a9b1d7be (qdev: define list of archs with virtio-pci 
or virtio-ccw)
17/22 Checking commit d9a5d5dfab12 (m68k: add the virtio devices aliases)
18/22 Checking commit c1434e384903 (blockdev: with -drive if=virtio, use 
generic virtio-blk)
19/22 Checking commit 175b36e18a3b (iotests: Revert "iotests: use -ccw on s390x 
for 040, 139, and 182")
20/22 Checking commit 7d603bdf27b0 (iotests: test m68k with the virt machine)
21/22 Checking commit 38b626694291 (iotests: iothreads need ioeventfd)
22/22 Checking commit bcc75474045f (gitlab: default to not building the 
documentation)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210323165308.15244-1-alex.bennee@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210323165308.15244-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com