qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 22/28] qapi: Prepare for rejecting underscore in command and


From: Eric Blake
Subject: Re: [PATCH 22/28] qapi: Prepare for rejecting underscore in command and member names
Date: Tue, 23 Mar 2021 10:15:03 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Command names and member names within a type should be all lower case
> with words separated by a hyphen.  We also accept underscore.  Rework
> check_name_lower() to optionally reject underscores, but don't use
> that option, yet.
> 
> Update expected test output for the changed error message.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  scripts/qapi/expr.py                    | 24 ++++++++++++++----------
>  tests/qapi-schema/args-member-case.err  |  2 +-
>  tests/qapi-schema/enum-member-case.err  |  2 +-
>  tests/qapi-schema/union-branch-case.err |  2 +-
>  4 files changed, 17 insertions(+), 13 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]