Re: [PATCH 13/28] qapi: Enforce event naming rules

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/28] qapi: Enforce event naming rules

From:	Eric Blake
Subject:	Re: [PATCH 13/28] qapi: Enforce event naming rules
Date:	Tue, 23 Mar 2021 09:32:04 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Event names should be ALL_CAPS with words separated by underscore.
> Enforce this.  The only offenders are in tests/.  Fix them.  Existing
> test event-case covers the new error.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 23/28] qapi: Enforce feature naming rules, (continued)
- [PATCH 23/28] qapi: Enforce feature naming rules, Markus Armbruster, 2021/03/23
  - Re: [PATCH 23/28] qapi: Enforce feature naming rules, Eric Blake, 2021/03/23
- [PATCH 21/28] tests-qmp-cmds: Drop unused and incorrect qmp_TestIfCmd(), Markus Armbruster, 2021/03/23
  - Re: [PATCH 21/28] tests-qmp-cmds: Drop unused and incorrect qmp_TestIfCmd(), Eric Blake, 2021/03/23
- [PATCH 18/28] tests/qapi-schema: Rename returns-whitelist to returns-bad-type, Markus Armbruster, 2021/03/23
  - Re: [PATCH 18/28] tests/qapi-schema: Rename returns-whitelist to returns-bad-type, Eric Blake, 2021/03/23
- [PATCH 28/28] qapi: Enforce union and alternate branch naming rules, Markus Armbruster, 2021/03/23
  - Re: [PATCH 28/28] qapi: Enforce union and alternate branch naming rules, Eric Blake, 2021/03/23
    - Re: [PATCH 28/28] qapi: Enforce union and alternate branch naming rules, Markus Armbruster, 2021/03/23
- [PATCH 13/28] qapi: Enforce event naming rules, Markus Armbruster, 2021/03/23
  - Re: [PATCH 13/28] qapi: Enforce event naming rules, Eric Blake <=
  - Re: [PATCH 13/28] qapi: Enforce event naming rules, John Snow, 2021/03/23
    - Re: [PATCH 13/28] qapi: Enforce event naming rules, Markus Armbruster, 2021/03/24
    - Re: [PATCH 13/28] qapi: Enforce event naming rules, John Snow, 2021/03/24
    - Re: [PATCH 13/28] qapi: Enforce event naming rules, Markus Armbruster, 2021/03/25
    - Re: [PATCH 13/28] qapi: Enforce event naming rules, John Snow, 2021/03/25
- [PATCH 10/28] qapi: Rework name checking in preparation of stricter checking, Markus Armbruster, 2021/03/23
  - Re: [PATCH 10/28] qapi: Rework name checking in preparation of stricter checking, Eric Blake, 2021/03/23
    - Re: [PATCH 10/28] qapi: Rework name checking in preparation of stricter checking, John Snow, 2021/03/23
    - Re: [PATCH 10/28] qapi: Rework name checking in preparation of stricter checking, Eric Blake, 2021/03/23
    - Re: [PATCH 10/28] qapi: Rework name checking in preparation of stricter checking, Markus Armbruster, 2021/03/23

Prev by Date: Re: [PATCH 12/28] qapi: Consistently permit any case in downstream prefixes
Next by Date: Re: [PATCH] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize()
Previous by thread: [PATCH 13/28] qapi: Enforce event naming rules
Next by thread: Re: [PATCH 13/28] qapi: Enforce event naming rules
Index(es):
- Date
- Thread