Re: [PATCH v3 4/8] meson: move qxl trace events to separate file

[Daniel P . Berrangé]

On Thu, Jan 21, 2021 at 01:50:24PM +0100, Gerd Hoffmann wrote:
> Move qxl trace events to separate trace-events-qxl file.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/qxl-render.c     |  1 +
>  hw/display/qxl.c            |  1 +
>  hw/display/meson.build      |  5 +++
>  hw/display/trace-events     | 67 -------------------------------------
>  hw/display/trace-events-qxl | 66 ++++++++++++++++++++++++++++++++++++
>  5 files changed, 73 insertions(+), 67 deletions(-)
>  create mode 100644 hw/display/trace-events-qxl
> 
> diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c
> index 3ce2e57b8feb..cc4862e26eb6 100644
> --- a/hw/display/qxl-render.c
> +++ b/hw/display/qxl-render.c
> @@ -23,6 +23,7 @@
>  #include "qxl.h"
>  #include "sysemu/runstate.h"
>  #include "trace.h"
> +#include "trace/trace-hw_display_qxl.h"

I'm not a fan of this, as it feels like we're setting
up a completely different naming convention from the
one that already exists.

The previous "trace.h" header is relative to the source
directory. ie, "trace.h" is pulling in "hw/display/trace.h".

IMHO, we should be generating 'trace-qxl.h', alongside
the existing trace.h, so we can use a bare "trace-qxl.h"
include that refers to "hw/display/trace-qxl.h".

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|