[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Is accel/stubs/ still needed? (resent)
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: Is accel/stubs/ still needed? (resent) |
|
Date: |
Mon, 22 Mar 2021 11:07:51 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/20/21 3:15 PM, Reinoud Zandijk wrote:
> Hi,
>
> a quick question. I forgot to add my accel/stubs/nvmm-stub.h
Stub ending in .h? Suspicious... Rename it .c?
> to
> accel/stubs/meson.build but even when I disable NVMM explicitly or build it on
> a NetBSD platform that does not support NVMM, it just compiled. So, is it
> actually still used?
Stub is usually required when you have to call specific code from
generic one. If your specific code is NVMM, then you should test
QEMU still builds outside of NetBSD / NVMM, where the NVMM stubs
would be used.
Regards,
Phil.