Re: [PULL 00/11] pflash patches for 2021-03-16

[Peter Maydell]

On Mon, 15 Mar 2021 at 23:37, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
>
>   Merge remote-tracking branch 
> 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-03-15 
> 19:23:00 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/philmd/qemu.git tags/pflash-20210316
>
> for you to fetch changes up to 3b6a1da064ac6ce5256f1f6f16870ea79c2422d0:
>
>   hw/block/pflash_cfi: Replace DPRINTF with trace events (2021-03-16 00:28:33 
> +0100)
>
> ----------------------------------------------------------------
> Parallel NOR Flash patches queue
>
> - Code movement to ease maintainability
> - Tracing improvements
> ----------------------------------------------------------------

Fails to build on 32-bit and OSX due to format string issues:

In file included from trace/trace-hw_block.c:5:
/Users/pm215/src/qemu-for-merges/hw/block/trace-events:36:38: error:
format specifies type 'unsigned long' but the argument has type
'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
                     , name, offset, len);
                                     ^~~
/Users/pm215/src/qemu-for-merges/hw/block/trace-events:33:121: error:
format specifies type 'unsigned long' but the argument has type
'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
            qemu_log("pflash_write_block_erase " "%s: block erase
offset:0x%" PRIx64 " bytes:0x%lx" "\n", name, offset, len);

                        ~~~                      ^~~

                        %llx


thanks
-- PMM