Re: [PULL for-6.0 0/6] qemu-ga patch queue for soft-freeze

[no-reply]

Patchew URL: 
20210317032217.1460684-1-michael.roth@amd.com/">https://patchew.org/QEMU/20210317032217.1460684-1-michael.roth@amd.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210317032217.1460684-1-michael.roth@amd.com
Subject: [PULL for-6.0 0/6] qemu-ga patch queue for soft-freeze

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210304123951.163411-1-joel@jms.id.au -> 
patchew/20210304123951.163411-1-joel@jms.id.au
 * [new tag]         patchew/20210317032217.1460684-1-michael.roth@amd.com -> 
patchew/20210317032217.1460684-1-michael.roth@amd.com
Switched to a new branch 'test'
737a2b0 qga: return a more explicit error on why a command is disabled
0bf8864 qga: Switch and case should be at the same indent
59f1523 qga: Open brace '{' following struct go on the same
9a65ca2 qga: Delete redundant spaces
f45a2c1 qga: Add spaces around operator
0a0eab1 qga: Correct loop count in qmp_guest_get_vcpus()

=== OUTPUT BEGIN ===
1/6 Checking commit 0a0eab1610f6 (qga: Correct loop count in 
qmp_guest_get_vcpus())
2/6 Checking commit f45a2c1f5bc7 (qga: Add spaces around operator)
3/6 Checking commit 9a65ca2783f0 (qga: Delete redundant spaces)
ERROR: spaces required around that '*' (ctx:WxV)
#34: FILE: qga/commands-win32.c:2177:
+    typedef NTSTATUS(WINAPI *rtl_get_version_t)(
                             ^

total: 1 errors, 0 warnings, 16 lines checked

Patch 3/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/6 Checking commit 59f152349ac0 (qga: Open brace '{' following struct go on 
the same)
5/6 Checking commit 0bf88641ae37 (qga: Switch and case should be at the same 
indent)
6/6 Checking commit 737a2b0e78d0 (qga: return a more explicit error on why a 
command is disabled)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210317032217.1460684-1-michael.roth@amd.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210317032217.1460684-1-michael.roth@amd.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com