Re: [PATCH v5 06/57] tcg/tci: Split out tci_args_rrrc

[Philippe Mathieu-Daudé]

On 3/11/21 3:39 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/tci.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/tcg/tci.c b/tcg/tci.c
> index 1c879a2536..bdd2127ec8 100644
> --- a/tcg/tci.c
> +++ b/tcg/tci.c
> @@ -207,6 +207,15 @@ static void tci_args_rrs(const uint8_t **tb_ptr,
>      *i2 = tci_read_s32(tb_ptr);
>  }
>  
> +static void tci_args_rrrc(const uint8_t **tb_ptr,
> +                          TCGReg *r0, TCGReg *r1, TCGReg *r2, TCGCond *c3)
> +{
> +    *r0 = tci_read_r(tb_ptr);
> +    *r1 = tci_read_r(tb_ptr);
> +    *r2 = tci_read_r(tb_ptr);
> +    *c3 = tci_read_b(tb_ptr);
> +}

Can you describe 'c -> cond' in the previous comment?

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>