Re: [PATCH 0/9] edid: windows fixes

[no-reply]

Patchew URL: 
20210316143812.2363588-1-kraxel@redhat.com/">https://patchew.org/QEMU/20210316143812.2363588-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210316143812.2363588-1-kraxel@redhat.com
Subject: [PATCH 0/9] edid: windows fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210212150256.885-1-zhiwei_liu@c-sky.com -> 
patchew/20210212150256.885-1-zhiwei_liu@c-sky.com
 - [tag update]      patchew/20210316135907.3646901-1-armbru@redhat.com -> 
patchew/20210316135907.3646901-1-armbru@redhat.com
 * [new tag]         patchew/20210316143812.2363588-1-kraxel@redhat.com -> 
patchew/20210316143812.2363588-1-kraxel@redhat.com
Switched to a new branch 'test'
abfdb3e edid: add support for DisplayID extension (5k resolution)
d330534 edid: allow arbitrary-length checksums
7543da1 edid: move timing generation into a separate function
0c42894 edid: Make refresh rate configurable
d12afa5 edid: prefer standard timings
5f683a4 edid: use dta extension block descriptors
c6dda2c edid: move xtra3 descriptor
572e698 edid: edid_desc_next
29d53b8 qemu-edid: use qemu_edid_size()

=== OUTPUT BEGIN ===
1/9 Checking commit 29d53b84d897 (qemu-edid: use qemu_edid_size())
2/9 Checking commit 572e698aa678 (edid: edid_desc_next)
3/9 Checking commit c6dda2cef0ef (edid: move xtra3 descriptor)
4/9 Checking commit 5f683a4f31e1 (edid: use dta extension block descriptors)
5/9 Checking commit d12afa5e5dd1 (edid: prefer standard timings)
6/9 Checking commit 0c42894ad0e4 (edid: Make refresh rate configurable)
WARNING: line over 80 characters
#33: FILE: hw/display/edid-generate.c:239:
+    uint64_t clock  = (uint64_t)refresh_rate * (xres + xblank) * (yres + 
yblank);

ERROR: Macros with complex values should be enclosed in parenthesis
#78: FILE: include/hw/display/edid.h:25:
+#define DEFINE_EDID_PROPERTIES(_state, _edid_info)                         \
+    DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0),               \
+    DEFINE_PROP_UINT32("yres", _state, _edid_info.prefy, 0),               \
+    DEFINE_PROP_UINT32("xmax", _state, _edid_info.maxx, 0),                \
+    DEFINE_PROP_UINT32("ymax", _state, _edid_info.maxy, 0),                \
+    DEFINE_PROP_UINT32("refresh_rate", _state, _edid_info.refresh_rate, 0)

total: 1 errors, 1 warnings, 57 lines checked

Patch 6/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/9 Checking commit 7543da15b755 (edid: move timing generation into a separate 
function)
8/9 Checking commit d330534fc64b (edid: allow arbitrary-length checksums)
9/9 Checking commit abfdb3e0f116 (edid: add support for DisplayID extension (5k 
resolution))
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210316143812.2363588-1-kraxel@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210316143812.2363588-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com