qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user: Use signed lengths in uaccess.c


From: no-reply
Subject: Re: [PATCH] linux-user: Use signed lengths in uaccess.c
Date: Mon, 15 Mar 2021 13:45:46 -0700 (PDT)

Patchew URL: 
20210315204004.2025219-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20210315204004.2025219-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210315204004.2025219-1-richard.henderson@linaro.org
Subject: [PATCH] linux-user: Use signed lengths in uaccess.c

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/20210315204004.2025219-1-richard.henderson@linaro.org -> 
patchew/20210315204004.2025219-1-richard.henderson@linaro.org
Switched to a new branch 'test'
cabd5c4 linux-user: Use signed lengths in uaccess.c

=== OUTPUT BEGIN ===
ERROR: externs should be avoided in .c files
#77: FILE: linux-user/uaccess.c:27:
+void unlock_user(void *host_ptr, abi_ulong guest_addr, ssize_t len);

total: 1 errors, 0 warnings, 81 lines checked

Commit cabd5c49328f (linux-user: Use signed lengths in uaccess.c) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210315204004.2025219-1-richard.henderson@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210315204004.2025219-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

reply via email to

[Prev in Thread] Current Thread [Next in Thread]