Re: [PATCH v8 29/35] Hexagon (target/hexagon) translation

[Richard Henderson]

On 3/14/21 9:06 PM, Taylor Simpson wrote:
> > Yes, but DISAS_NORETURN still means we've already exited.
> >
> > Just like calling abort() in C means that we won't reach any following return 
> > statement.
>
> Then I'm missing something because the code emitted here does get executed.

You really are missing the point.

The code emitted here, for the NORETURN case, gets executed?  How do you know? 
 And if so, then *something* is returning when it shouldn't.

The stop hook is for the use of all of the *other* DISAS_* codes, for which we 
have not yet exited.

There should be *nothing* to be done for NORETURN.  We have longjmp'ed away to 
the main loop already.  Anything that needed to be done must have been done 
before that point.


r~