Re: [PATCH] utils: Reduce chance of rounding inaccuracy in qemu_strtosz.

[Richard Henderson]

On 3/15/21 5:33 AM, Eric Blake wrote:
> On 3/13/21 3:48 PM, Richard Henderson wrote:
> > On 3/11/21 2:07 PM, Eric Blake wrote:
> > > +        /*
> > > +         * Add in a fudge-factor (2^53 when double is IEEE format) for
> > > +         * all scales less than P (2^50), so that things like
> > > +         * 12.345M with unit 1000 produce 12345000 instead of
> > > +         * 12344999.
> > > +         */
> > > +        if (mul > 1e49) {
> >
> > The comment says less than, the code says greater than.
>
> Shoot. A demonstration that I did not have an environment that actually
> reproduced the bug

Any i686 vm will do.  I had a debian 10 vm hanging around in which I could 
reproduce it.


r~