RE: [PATCH v8 13/35] Hexagon (target/hexagon) instruction/packet decode

[Taylor Simpson]

> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Sunday, February 14, 2021 12:32 PM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: philmd@redhat.com; alex.bennee@linaro.org; laurent@vivier.eu;
> ale@rev.ng; Brian Cain <bcain@quicinc.com>
> Subject: Re: [PATCH v8 13/35] Hexagon (target/hexagon) instruction/packet
> decode
>
> On 2/7/21 9:46 PM, Taylor Simpson wrote:
> > +#define DECODE_MAPPED_REG(REGNO, NAME) \
> > +    insn->regno[REGNO] = DECODE_REGISTER_##NAME[insn-
> >regno[REGNO]];
>
> The macro argument is not a regno, but an operand number.

OK

> Please have another look through and use bool as reasonable.

OK