|
| From: | Richard Henderson |
| Subject: | Re: [PATCH 05/11] hw/gpio/avr_gpio: Add 'id' field in AVRGPIOState |
| Date: | Sat, 13 Mar 2021 13:58:53 -0600 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 3/13/21 10:54 AM, Philippe Mathieu-Daudé wrote:
+ if (s->id == UINT8_MAX) {
+ error_setg(errp, "property 'id' not set");
+ return;
+ }
This error message would be a tad confusing if one set the id to 255. What's the point?
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |