Re: [PATCH v8 0/5] m68k: add Virtual M68k Machine

[Philippe Mathieu-Daudé]

On 3/12/21 10:41 PM, Laurent Vivier wrote:
> The Quadra 800 machine is very limited to run linux, it manages
> only 1 GiB of memory and only some specific interfaces.
> 
> The Virtual M68k Machine is based on Goldfish interfaces defined by Google
> for Android simulator. It uses Goldfish-rtc (timer and RTC),
> Goldfish-pic (PIC) and Goldfish-tty (for early tty).

> v8:
>   goldfish-tty:
>     set version to 1 because, as pointed out by Peter, the version 0
>     provides virtual address and not physical address to QEMU.
>     It was working with m68k-virt kernel because virtual memory
>     of the kernel is mapped at the same address as the physical memory.
>     The m68k-virt kernel at this point is not ready to use the
>     goldfish tty driver with the physical address but we can
>     use the virtio-serial interface. We keep the goldfish-tty device
>     for the early printks that work fine because they use the PUT_CHAR
>     register.

v8 LGTM.