Re: [PATCH 0/3] vl: QAPIfy -object

[no-reply]

Patchew URL: 
20210311172459.990281-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210311172459.990281-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210311172459.990281-1-pbonzini@redhat.com
Subject: [PATCH 0/3] vl: QAPIfy -object

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210310154526.463850-1-pbonzini@redhat.com -> 
patchew/20210310154526.463850-1-pbonzini@redhat.com
 * [new tag]         patchew/20210311172459.990281-1-pbonzini@redhat.com -> 
patchew/20210311172459.990281-1-pbonzini@redhat.com
Switched to a new branch 'test'
56d1575 vl: allow passing JSON to -object
320d5b3 qom: move user_creatable_add_opts logic to vl.c and QAPIfy it
645f9df tests: convert check-qom-proplist to keyval

=== OUTPUT BEGIN ===
1/3 Checking commit 645f9dfaea05 (tests: convert check-qom-proplist to keyval)
2/3 Checking commit 320d5b301968 (qom: move user_creatable_add_opts logic to 
vl.c and QAPIfy it)
WARNING: line over 80 characters
#192: FILE: softmmu/vl.c:145:
+static QTAILQ_HEAD(, ObjectOption) object_opts = 
QTAILQ_HEAD_INITIALIZER(object_opts);

ERROR: line over 90 characters
#200: FILE: softmmu/vl.c:1694:
+static void object_option_foreach_add(bool (*type_opt_predicate)(const char 
*), Error **errp)

total: 1 errors, 1 warnings, 253 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 56d1575bce1e (vl: allow passing JSON to -object)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210311172459.990281-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210311172459.990281-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com