qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL v2 03/19] roms/opensbi: Upgrade from v0.8 to v0.9


From: Alistair Francis
Subject: Re: [PULL v2 03/19] roms/opensbi: Upgrade from v0.8 to v0.9
Date: Thu, 11 Mar 2021 10:48:44 -0500

On Tue, Mar 9, 2021 at 11:51 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Hi Alistair,
>
> On 3/4/21 3:46 PM, Alistair Francis wrote:
> > From: Bin Meng <bin.meng@windriver.com>
> >
> > Upgrade OpenSBI from v0.8 to v0.9 and the pre-built bios images.
>
> > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> > Message-Id: 20210119234438.10132-1-bmeng.cn@gmail.com
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> >  .../opensbi-riscv32-generic-fw_dynamic.bin    | Bin 62144 -> 78680 bytes
> >  .../opensbi-riscv32-generic-fw_dynamic.elf    | Bin 558668 -> 727464 bytes
> >  .../opensbi-riscv64-generic-fw_dynamic.bin    | Bin 70792 -> 75096 bytes
> >  .../opensbi-riscv64-generic-fw_dynamic.elf    | Bin 620424 -> 781264 bytes
> >  roms/opensbi                                  |   2 +-
> >  5 files changed, 1 insertion(+), 1 deletion(-)
>
> For pull-request you can use git-format-patch with --no-binary:
>
>    --no-binary
>            Do not output contents of changes in binary files,
>            instead display a notice that those files changed.
>            Patches generated using this option cannot be applied
>            properly, but they are still useful for code review.

Thanks, I have updated my script (which is really Peter's script) to add that.

Alistair

>
> I did the same mistake last year and this broke QEMU patchwork
> instance. No sure it is still in use, so Cc'ing Stefan.
>
> > diff --git a/roms/opensbi b/roms/opensbi
> > index a98258d0b5..234ed8e427 160000
> > --- a/roms/opensbi
> > +++ b/roms/opensbi
> > @@ -1 +1 @@
> > -Subproject commit a98258d0b537a295f517bbc8d813007336731fa9
> > +Subproject commit 234ed8e427f4d92903123199f6590d144e0d9351
> >
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]