Re: [PATCH 1/4] usb: remove support for -usbdevice parameters

[Eric Blake]

On 3/10/21 11:33 AM, Thomas Huth wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> No device needs them anymore and in fact they're undocumented.
> Remove the code.  The only change in behavior is that "-usbdevice
> braille:hello" now reports an error, which is a bugfix.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/usb/bus.c        | 32 +++++++-------------------------
>  hw/usb/dev-serial.c |  2 +-
>  include/hw/usb.h    |  2 +-
>  3 files changed, 9 insertions(+), 27 deletions(-)
> 

> +    if (strchr(driver, ':')) {
> +        error_report("usbdevice parameters are not supported anymore");

Although wiktionary says it is a valid word in the US, 'anymore' feels
colloquial compared to 'any more'.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org