qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument


From: Gerd Hoffmann
Subject: Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument
Date: Wed, 10 Mar 2021 13:22:23 +0100

> > > +    if (bundle) {
> >
> > Does this break about window if the executable is not in a bundle (like
> > when run from the command line after compiling)? Shouldn't you only put
> > the qemu_name in this if and have some default name if bundle is not
> > available (or fall back to argv[0] in that case?
> >
> > Regards,
> > BALATON Zoltan
> >
> 
> No, it just doesn't show the application name. Everything else is fine.

Having a fallback would still be nice, even if it is just the fixed
string "qemu".  Starting a fresh build without installing it first is
common while developing.

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]