|
| From: | Paolo Bonzini |
| Subject: | Re: [PATCH] scsi: fix sense code for EREMOTEIO |
| Date: | Tue, 9 Mar 2021 15:22:35 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 09/03/21 15:14, Philippe Mathieu-Daudé wrote:
SENSE_CODE(LUN_COMM_FAILURE) has an ABORTED COMMAND sense key, so it results in a retry in Linux. To ensure that EREMOTEIO is forwarded to the guest, use a HARDWARE ERROR sense key instead. Note that the code before commit d7a84021d was incorrect because it used HARDWARE_ERROR as a SCSI status, not as a sense key.It is not clear whether if it deserves a 'Fixes: d7a84021db8 ("scsi: introduce scsi_sense_from_errno()")' or not...
Yes, why not. That was in turn a bugfix but not the best. Paolo
Reported-by: Marc-André Lureau<marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>Reviewed-by: Philippe Mathieu-Daudé<philmd@redhat.com>
| [Prev in Thread] | Current Thread | [Next in Thread] |