qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V2] virtio-net: calculating proper msix vectors on init


From: Stefano Garzarella
Subject: Re: [PATCH V2] virtio-net: calculating proper msix vectors on init
Date: Tue, 9 Mar 2021 12:13:26 +0100

On Tue, Mar 09, 2021 at 12:23:14PM +0800, Jason Wang wrote:
Currently, the default msix vectors for virtio-net-pci is 3 which is
obvious not suitable for multiqueue guest, so we depends on the user
or management tools to pass a correct vectors parameter. In fact, we
can simplifying this by calculating the number of vectors on realize.

Consider we have N queues, the number of vectors needed is 2*N + 2
(#queue pairs + plus one config interrupt and control vq). We didn't
check whether or not host support control vq because it was added
unconditionally by qemu to avoid breaking legacy guests such as Minix.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
Changes since v1:
- Fix typo in the commit log
- Explain the magic number during vectors calculation
---
hw/core/machine.c          |  1 +
hw/virtio/virtio-net-pci.c | 10 +++++++++-
2 files changed, 10 insertions(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]