qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets


From: Paolo Bonzini
Subject: Re: [RFC PATCH v2] meson: Only generate trace files for selected targets
Date: Tue, 9 Mar 2021 11:26:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 09/03/21 09:41, Claudio Fontana wrote:
In any case, I agree that just recursing all directories in target/
looking for trace.h / traceevents files could be better.

Using the directory structure to find source files is a bad idea because you don't notice that you haven't "git add"ed a file until it's too late (typically the maintainer notices it for you...).

We do it for default-configs/targets, but that's an exception and I'd rather not extend it more.

In fact, Philippe, perhaps you can add the extra tracedirs for hw/ and target/ to the default-config/targets/*.mak file?

Thanks,

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]