[Bug 1916655] Re: Compilation fails due to zstd qcow2 compression

[John Snow]

Meson theoretically checks for that:

meson.build:  zstd = dependency('libzstd', version: '>=1.4.0',

I suppose meson found the dependency, but the compile flags got the
wrong header. Is there something we need to fix in the build system?

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1916655

Title:
  Compilation fails due to zstd qcow2 compression

Status in QEMU:
  Invalid

Bug description:
  Compilation of QEMU fails when using recent versions of zstd.

  I use the following commands to compile QEMU:
  $ mkdir build
  $ cd build
  $ ../configure --enable-debug --target-list=x86_64-softmmu
  $ make -j $(nproc)

  Here is a paste from the ../configure output:
  https://paste.ubuntu.com/p/dHsWzGV7TH/

  And one from the make output:
  https://paste.ubuntu.com/p/89qKk4NrFz/

  In short the error boils down to:
  ../block/qcow2-threads.c: In function ‘qcow2_zstd_compress’:
  ../block/qcow2-threads.c:225:16: error: implicit declaration of function 
‘ZSTD_compressStream2’; did you mean ‘ZSTD_compressStream’? 
[-Werror=implicit-function-declaration]
    225 |     zstd_ret = ZSTD_compressStream2(cctx, &output, &input, 
ZSTD_e_end);
        |                ^~~~~~~~~~~~~~~~~~~~
        |                ZSTD_compressStream
  ../block/qcow2-threads.c:225:16: error: nested extern declaration of 
‘ZSTD_compressStream2’ [-Werror=nested-externs]
  ../block/qcow2-threads.c:225:60: error: ‘ZSTD_e_end’ undeclared (first use in 
this function)
    225 |     zstd_ret = ZSTD_compressStream2(cctx, &output, &input, 
ZSTD_e_end);
        |

  System info:
  QEMU commit: 7ef8134565dccf9186d5eabd7dbb4ecae6dead87 (from Github)
  Kernel: 5.10.15
  zstd: 1.4.8

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1916655/+subscriptions