Re: [PULL 00/18] testing, docs, semihosting move and guest-loader

[no-reply]

Patchew URL: 
20210308135104.24903-1-alex.bennee@linaro.org/">https://patchew.org/QEMU/20210308135104.24903-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210308135104.24903-1-alex.bennee@linaro.org
Subject: [PULL 00/18] testing, docs, semihosting move and guest-loader

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210308135104.24903-1-alex.bennee@linaro.org -> 
patchew/20210308135104.24903-1-alex.bennee@linaro.org
Switched to a new branch 'test'
d4615d7 semihosting: Move hw/semihosting/ -> semihosting/
11ff336 semihosting: Move include/hw/semihosting/ -> include/semihosting/
6ff470d tests/avocado: add boot_xen tests
366972f docs: add some documentation for the guest-loader
2de6334 docs: move generic-loader documentation into the main manual
3540331 hw/core: implement a guest-loader to support static hypervisor guests
59152d4 device_tree: add qemu_fdt_setprop_string_array helper
5e73c0a hw/riscv: migrate fdt field to generic MachineState
97b2110 hw/board: promote fdt from ARM VirtMachineState to MachineState
8e087e0 .editorconfig: update the automatic mode setting for Emacs
b19b8a9 tests/docker: Use --arch-only when building Debian cross image
7904ddd gitlab-ci.yml: Add jobs to test CFI flags
c0b1a18 gitlab-ci.yml: Allow custom # of parallel linkers
06aaa2a gitlab: add build-user-hexagon test
6e13d36 tests/tcg: Use Hexagon Docker image
d1e83eb docker: Add Hexagon image
0cedc72 tests/docker: add a test-tcg for building then running check-tcg
1463a1a docs/system: add a gentle prompt for the complexity to come

=== OUTPUT BEGIN ===
1/18 Checking commit 1463a1add7ee (docs/system: add a gentle prompt for the 
complexity to come)
2/18 Checking commit 0cedc725cfc7 (tests/docker: add a test-tcg for building 
then running check-tcg)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100755

total: 0 errors, 1 warnings, 22 lines checked

Patch 2/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/18 Checking commit d1e83ebe6917 (docker: Add Hexagon image)
WARNING: line over 80 characters
#154: FILE: 
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63:
+    -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic 
--target=hexagon-unknown-linux-musl " \

ERROR: line over 90 characters
#181: FILE: 
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90:
+    CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math 
--target=hexagon-unknown-linux-musl" \

ERROR: line over 90 characters
#218: FILE: 
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127:
+    CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math 
--target=hexagon-unknown-linux-musl" \

total: 2 errors, 1 warnings, 184 lines checked

Patch 3/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/18 Checking commit 6e13d36db441 (tests/tcg: Use Hexagon Docker image)
5/18 Checking commit 06aaa2a233b0 (gitlab: add build-user-hexagon test)
6/18 Checking commit c0b1a1890207 (gitlab-ci.yml: Allow custom # of parallel 
linkers)
7/18 Checking commit 7904dddf9a7d (gitlab-ci.yml: Add jobs to test CFI flags)
8/18 Checking commit b19b8a9ffcc3 (tests/docker: Use --arch-only when building 
Debian cross image)
9/18 Checking commit 8e087e006cee (.editorconfig: update the automatic mode 
setting for Emacs)
10/18 Checking commit 97b211043a1b (hw/board: promote fdt from ARM 
VirtMachineState to MachineState)
11/18 Checking commit 5e73c0a7598b (hw/riscv: migrate fdt field to generic 
MachineState)
12/18 Checking commit 59152d4b2f5e (device_tree: add 
qemu_fdt_setprop_string_array helper)
13/18 Checking commit 354033138a38 (hw/core: implement a guest-loader to 
support static hypervisor guests)
14/18 Checking commit 2de63345e199 (docs: move generic-loader documentation 
into the main manual)
15/18 Checking commit 366972f9a48b (docs: add some documentation for the 
guest-loader)
16/18 Checking commit 6ff470d25fc6 (tests/avocado: add boot_xen tests)
WARNING: line over 80 characters
#96: FILE: tests/acceptance/boot_xen.py:56:
+                         
'guest-loader,addr=0x47000000,kernel=%s,bootargs=console=hvc0'

WARNING: line over 80 characters
#118: FILE: tests/acceptance/boot_xen.py:78:
+                   
'xen-hypervisor-4.11-arm64_4.11.4%2B37-g3263f257ca-1_arm64.deb')

WARNING: line over 80 characters
#136: FILE: tests/acceptance/boot_xen.py:96:
+                   
'xen-hypervisor-4.14-arm64_4.14.0%2B80-gd101b417b7-1_arm64.deb')

total: 0 errors, 3 warnings, 125 lines checked

Patch 16/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/18 Checking commit 11ff336713dd (semihosting: Move include/hw/semihosting/ 
-> include/semihosting/)
18/18 Checking commit d4615d7502e5 (semihosting: Move hw/semihosting/ -> 
semihosting/)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210308135104.24903-1-alex.bennee@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210308135104.24903-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com