Re: [PATCH v4 1/5] char: add goldfish-tty

[Richard Henderson]

On 3/7/21 11:57 AM, Laurent Vivier wrote:
> Le 07/03/2021 à 20:24, Philippe Mathieu-Daudé a écrit :
> > The spec says this register is only available on 64-bit targets.
> >
> > Should we restrict this "#if TARGET_LONG_SIZE == 8"?
> > else log_mask(GUEST_ERROR)...
> >
> > This seems overkill to me but that would respect the spec.
>
> TARGET_LONG_SIZE depends on CPU, I don't think we can use it here.

TARGET_LONG_BITS is in fact poisoned -- you can't use it here.


r~