qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user: add missing MULTICAST_IF get/setsockopt option


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] linux-user: add missing MULTICAST_IF get/setsockopt option
Date: Fri, 5 Mar 2021 10:34:46 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 3/5/21 4:46 AM, Jiaxun Yang wrote:
> 在 2021/3/5 上午11:35, Jiaxun Yang 写道:
> 
>> {IP,IPV6}_MULTICAST_IF was not supported.
> 
>>
> 
>> Reported-by: Yunqiang Su <syq@debian.org>
> 
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> 
>> ---
> 
>>   linux-user/syscall.c      |     4 +
> 
>>   linux-user/syscall.c.orig | 13305
> ++++++++++++++++++++++++++++++++++++^ Sorry ^ ^ sorry for the noise...
> 
> I'm drunk today.

Suggestions:

- it might be OK to commit being drunk, but always better post the
  next day after reviewing the previous commits ;)
- use 'git-add -p' instead of 'git-add .'

Regards,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]