[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v3 04/10] hw/net: vmxnet3: Remove the logic of padding short
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH v3 04/10] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path |
Date: |
Wed, 3 Mar 2021 20:11:59 +0100 |
From: Bin Meng <bin.meng@windriver.com>
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
This actually reverts commit 40a87c6c9b11ef9c14e0301f76abf0eb2582f08e.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <1614763306-18026-4-git-send-email-bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/net/vmxnet3.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index eff299f6290..d993cce097a 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -39,7 +39,6 @@
#define PCI_DEVICE_ID_VMWARE_VMXNET3_REVISION 0x1
#define VMXNET3_MSIX_BAR_SIZE 0x2000
-#define MIN_BUF_SIZE 60
/* Compatibility flags for migration */
#define VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS_BIT 0
@@ -1951,7 +1950,6 @@ vmxnet3_receive(NetClientState *nc, const uint8_t *buf,
size_t size)
{
VMXNET3State *s = qemu_get_nic_opaque(nc);
size_t bytes_indicated;
- uint8_t min_buf[MIN_BUF_SIZE];
if (!vmxnet3_can_receive(nc)) {
VMW_PKPRN("Cannot receive now");
@@ -1964,14 +1962,6 @@ vmxnet3_receive(NetClientState *nc, const uint8_t *buf,
size_t size)
size -= sizeof(struct virtio_net_hdr);
}
- /* Pad to minimum Ethernet frame length */
- if (size < sizeof(min_buf)) {
- memcpy(min_buf, buf, size);
- memset(&min_buf[size], 0, sizeof(min_buf) - size);
- buf = min_buf;
- size = sizeof(min_buf);
- }
-
net_rx_pkt_set_packet_type(s->rx_pkt,
get_eth_packet_type(PKT_GET_ETH_HDR(buf)));
--
2.26.2
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, (continued)
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Peter Maydell, 2021/03/11
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Bin Meng, 2021/03/11
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Peter Maydell, 2021/03/11
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Bin Meng, 2021/03/11
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Jason Wang, 2021/03/12
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Bin Meng, 2021/03/12
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Jason Wang, 2021/03/12
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Bin Meng, 2021/03/12
- Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP, Jason Wang, 2021/03/12
[RFC PATCH v3 03/10] hw/net: e1000: Remove the logic of padding short frames in the receive path, Philippe Mathieu-Daudé, 2021/03/03
[RFC PATCH v3 04/10] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path,
Philippe Mathieu-Daudé <=
[RFC PATCH v3 05/10] hw/net: i82596: Remove the logic of padding short frames in the receive path, Philippe Mathieu-Daudé, 2021/03/03
[RFC PATCH v3 06/10] hw/net: ne2000: Remove the logic of padding short frames in the receive path, Philippe Mathieu-Daudé, 2021/03/03
[RFC PATCH v3 07/10] hw/net: pcnet: Remove the logic of padding short frames in the receive path, Philippe Mathieu-Daudé, 2021/03/03
[RFC PATCH v3 08/10] hw/net: rtl8139: Remove the logic of padding short frames in the receive path, Philippe Mathieu-Daudé, 2021/03/03
[RFC PATCH v3 10/10] hw/net: sunhme: Remove the logic of padding short frames in the receive path, Philippe Mathieu-Daudé, 2021/03/03
[RFC PATCH v3 09/10] hw/net: sungem: Remove the logic of padding short frames in the receive path, Philippe Mathieu-Daudé, 2021/03/03
Re: [RFC PATCH v3 00/10] net: Handle short frames for SLiRP/TAP interfaces, Bin Meng, 2021/03/07