[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] coreaudio: Handle output device change
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 2/2] coreaudio: Handle output device change |
Date: |
Wed, 3 Mar 2021 10:27:00 +0100 |
Hi,
> status = coreaudio_get_voice(&core->outputDeviceID);
> if (status != kAudioHardwareNoError) {
> - coreaudio_logerr2 (status, typ,
> - "Could not get default output Device\n");
> - return -1;
> + coreaudio_playback_logerr (status,
> + "Could not get default output Device\n");
> + return status;
This "pass status code to caller" change can and should be splitted to a
separate patch.
Likewise with the logging changes.
That makes the patch with the actual functional change to deal with the
device changes smaller and easier to review.
thanks,
Gerd