[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 5/9] hw/net: ne2000: Remove the logic of padding short fra
From: |
Bin Meng |
Subject: |
[RFC PATCH v2 5/9] hw/net: ne2000: Remove the logic of padding short frames in the receive path |
Date: |
Wed, 3 Mar 2021 17:21:42 +0800 |
From: Bin Meng <bin.meng@windriver.com>
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
(no changes since v1)
hw/net/ne2000.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
index 6c17ee1..b0a120e 100644
--- a/hw/net/ne2000.c
+++ b/hw/net/ne2000.c
@@ -167,15 +167,12 @@ static int ne2000_buffer_full(NE2000State *s)
return 0;
}
-#define MIN_BUF_SIZE 60
-
ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
{
NE2000State *s = qemu_get_nic_opaque(nc);
size_t size = size_;
uint8_t *p;
unsigned int total_len, next, avail, len, index, mcast_idx;
- uint8_t buf1[60];
static const uint8_t broadcast_macaddr[6] =
{ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
@@ -213,15 +210,6 @@ ssize_t ne2000_receive(NetClientState *nc, const uint8_t
*buf, size_t size_)
}
}
-
- /* if too small buffer, then expand it */
- if (size < MIN_BUF_SIZE) {
- memcpy(buf1, buf, size);
- memset(buf1 + size, 0, MIN_BUF_SIZE - size);
- buf = buf1;
- size = MIN_BUF_SIZE;
- }
-
index = s->curpag << 8;
if (index >= NE2000_PMEM_END) {
index = s->start;
--
2.7.4
- [RFC PATCH v2 0/9] net: Handle short frames for SLiRP/TAP interfaces, Bin Meng, 2021/03/03
- [RFC PATCH v2 1/9] net: Pad short frames to minimum size before send from SLiRP/TAP, Bin Meng, 2021/03/03
- [RFC PATCH v2 2/9] hw/net: e1000: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/03
- [RFC PATCH v2 3/9] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/03
- [RFC PATCH v2 4/9] hw/net: i82596: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/03
- [RFC PATCH v2 5/9] hw/net: ne2000: Remove the logic of padding short frames in the receive path,
Bin Meng <=
- [RFC PATCH v2 6/9] hw/net: pcnet: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/03
- [RFC PATCH v2 7/9] hw/net: rtl8139: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/03
- [RFC PATCH v2 8/9] hw/net: sungem: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/03
- [RFC PATCH v2 9/9] hw/net: sunhme: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/03