Re: [PATCH v3] vl: deprecate -writeconfig

[no-reply]

Patchew URL: 
20210302180023.54555-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210302180023.54555-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210302180023.54555-1-pbonzini@redhat.com
Subject: [PATCH v3] vl: deprecate -writeconfig

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210302180023.54555-1-pbonzini@redhat.com -> 
patchew/20210302180023.54555-1-pbonzini@redhat.com
Switched to a new branch 'test'
25b4cd1 vl: deprecate -writeconfig

=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#66: FILE: softmmu/vl.c:3359:
+                    warn_report("-writeconfig is deprecated and will go away 
without a replacement");

total: 1 errors, 0 warnings, 34 lines checked

Commit 25b4cd1060d2 (vl: deprecate -writeconfig) has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210302180023.54555-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210302180023.54555-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com