Re: [PATCH 00/27] tcg patch queue

[no-reply]

Patchew URL: 
20210302175741.1079851-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20210302175741.1079851-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210302175741.1079851-1-richard.henderson@linaro.org
Subject: [PATCH 00/27] tcg patch queue

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/20210302175741.1079851-1-richard.henderson@linaro.org -> 
patchew/20210302175741.1079851-1-richard.henderson@linaro.org
Switched to a new branch 'test'
21d314e accel/tcg: Precompute curr_cflags into cpu->tcg_cflags
ec7e203 include/exec: lightly re-arrange TranslationBlock
1eb4564 accel/tcg: drop the use of CF_HASH_MASK and rename params
1310fe7 accel/tcg: move CF_CLUSTER calculation to curr_cflags
0b90b61 accel/tcg: rename tb_lookup__cpu_state and hoist state extraction
1b00a3d tcg/tci: Merge mov, not and neg operations
1cee957 tcg/tci: Merge bswap operations
3fd0a39 tcg/tci: Merge extension operations
47f2fdb tcg/tci: Merge basic arithmetic operations
a29c461 tcg/tci: Reduce use of tci_read_r64
da25d80 tcg/tci: Remove tci_read_r32s
318f0e5 tcg/tci: Remove tci_read_r32
daeee81 tcg/tci: Remove tci_read_r16s
c08bc50 tcg/tci: Remove tci_read_r16
ea6b7cf tcg/tci: Remove tci_read_r8s
05c0eed tcg/tci: Remove tci_read_r8
7bb5c47 tcg/tci: Merge identical cases in generation (load/store opcodes)
562c994 tcg/tci: Merge identical cases in generation (conditional opcodes)
912a855 tcg/tci: Merge identical cases in generation (deposit opcode)
f6c5c68 tcg/tci: Merge identical cases in generation (exchange opcodes)
1790435 tcg/tci: Merge identical cases in generation (arithmetic opcodes)
1c4ef56 tcg: Manage splitwx in tc_ptr_to_region_tree by hand
cd668a2 tcg: Split out tcg_raise_tb_overflow
0b498ee tcg/tci: Use exec/cpu_ldst.h interfaces
bbb2d17 tcg/aarch64: Fix generation of "scalar" vector operations
84327ea tcg/aarch64: Fix I3617_CMLE0
495fb66 tcg/aarch64: Fix constant subtraction in tcg_out_addsub2

=== OUTPUT BEGIN ===
1/27 Checking commit 495fb66adaef (tcg/aarch64: Fix constant subtraction in 
tcg_out_addsub2)
2/27 Checking commit 84327ea79eae (tcg/aarch64: Fix I3617_CMLE0)
3/27 Checking commit bbb2d17578d2 (tcg/aarch64: Fix generation of "scalar" 
vector operations)
4/27 Checking commit 0b498eec9b38 (tcg/tci: Use exec/cpu_ldst.h interfaces)
5/27 Checking commit cd668a228ac2 (tcg: Split out tcg_raise_tb_overflow)
6/27 Checking commit 1c4ef5688ba1 (tcg: Manage splitwx in tc_ptr_to_region_tree 
by hand)
7/27 Checking commit 17904359fb42 (tcg/tci: Merge identical cases in generation 
(arithmetic opcodes))
8/27 Checking commit f6c5c687ee1a (tcg/tci: Merge identical cases in generation 
(exchange opcodes))
9/27 Checking commit 912a855e80bd (tcg/tci: Merge identical cases in generation 
(deposit opcode))
10/27 Checking commit 562c9948ddb4 (tcg/tci: Merge identical cases in 
generation (conditional opcodes))
11/27 Checking commit 7bb5c47232c7 (tcg/tci: Merge identical cases in 
generation (load/store opcodes))
12/27 Checking commit 05c0eed62955 (tcg/tci: Remove tci_read_r8)
13/27 Checking commit ea6b7cf413ec (tcg/tci: Remove tci_read_r8s)
14/27 Checking commit c08bc504aa5a (tcg/tci: Remove tci_read_r16)
15/27 Checking commit daeee814c6b2 (tcg/tci: Remove tci_read_r16s)
16/27 Checking commit 318f0e554cf7 (tcg/tci: Remove tci_read_r32)
17/27 Checking commit da25d80e0b0b (tcg/tci: Remove tci_read_r32s)
18/27 Checking commit a29c461bbeff (tcg/tci: Reduce use of tci_read_r64)
19/27 Checking commit 47f2fdb34c24 (tcg/tci: Merge basic arithmetic operations)
20/27 Checking commit 3fd0a391bd20 (tcg/tci: Merge extension operations)
21/27 Checking commit 1cee9575f173 (tcg/tci: Merge bswap operations)
22/27 Checking commit 1b00a3da1fd3 (tcg/tci: Merge mov, not and neg operations)
23/27 Checking commit 0b90b616952e (accel/tcg: rename tb_lookup__cpu_state and 
hoist state extraction)
ERROR: "foo * bar" should be "foo *bar"
#86: FILE: include/exec/tb-lookup.h:20:
+static inline TranslationBlock * tb_lookup(CPUState *cpu,

WARNING: line over 80 characters
#87: FILE: include/exec/tb-lookup.h:21:
+                                           target_ulong pc, target_ulong 
cs_base,

total: 1 errors, 1 warnings, 80 lines checked

Patch 23/27 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/27 Checking commit 1310fe752847 (accel/tcg: move CF_CLUSTER calculation to 
curr_cflags)
25/27 Checking commit 1eb456458332 (accel/tcg: drop the use of CF_HASH_MASK and 
rename params)
26/27 Checking commit ec7e20384f56 (include/exec: lightly re-arrange 
TranslationBlock)
WARNING: Block comments use a leading /* on a separate line
#37: FILE: include/exec/exec-all.h:465:
+    uint16_t size;      /* size of target code for this block (1 <=

WARNING: Block comments use * on subsequent lines
#38: FILE: include/exec/exec-all.h:466:
+    uint16_t size;      /* size of target code for this block (1 <=
+                           size <= TARGET_PAGE_SIZE) */

WARNING: Block comments use a trailing */ on a separate line
#38: FILE: include/exec/exec-all.h:466:
+                           size <= TARGET_PAGE_SIZE) */

total: 0 errors, 3 warnings, 20 lines checked

Patch 26/27 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/27 Checking commit 21d314eebbfb (accel/tcg: Precompute curr_cflags into 
cpu->tcg_cflags)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210302175741.1079851-1-richard.henderson@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210302175741.1079851-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com