Re: [PATCH 0/2] semihosting: Move it out of hw/

[Claudio Fontana]

Hi Philippe,

On 3/2/21 3:10 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing Claudio.
> 
> On 2/26/21 2:13 PM, Philippe Mathieu-Daudé wrote:
>> In order to reduce CONFIG_USER_ONLY uses in hw/, move
>> semihosting out of it, being a generic feature.

I have nothing against it, just what does this buy us?

Maybe I am just missing the point..

Ciao,

Claudio

>>
>> Philippe Mathieu-Daudé (2):
>>   semihosting: Move include/hw/semihosting/ -> include/semihosting/
>>   semihosting: Move hw/semihosting/ -> semihosting/
>>
>>  meson.build                                       | 1 +
>>  include/{hw => }/semihosting/console.h            | 0
>>  include/{hw => }/semihosting/semihost.h           | 0
>>  {hw/semihosting => semihosting}/common-semi.h     | 0
>>  gdbstub.c                                         | 2 +-
>>  hw/mips/malta.c                                   | 2 +-
>>  linux-user/aarch64/cpu_loop.c                     | 2 +-
>>  linux-user/arm/cpu_loop.c                         | 2 +-
>>  linux-user/riscv/cpu_loop.c                       | 2 +-
>>  linux-user/semihost.c                             | 2 +-
>>  {hw/semihosting => semihosting}/arm-compat-semi.c | 6 +++---
>>  {hw/semihosting => semihosting}/config.c          | 2 +-
>>  {hw/semihosting => semihosting}/console.c         | 4 ++--
>>  softmmu/vl.c                                      | 2 +-
>>  stubs/semihost.c                                  | 2 +-
>>  target/arm/helper.c                               | 4 ++--
>>  target/arm/m_helper.c                             | 4 ++--
>>  target/arm/translate-a64.c                        | 2 +-
>>  target/arm/translate.c                            | 2 +-
>>  target/lm32/helper.c                              | 2 +-
>>  target/m68k/op_helper.c                           | 2 +-
>>  target/mips/cpu.c                                 | 2 +-
>>  target/mips/mips-semi.c                           | 4 ++--
>>  target/mips/translate.c                           | 2 +-
>>  target/nios2/helper.c                             | 2 +-
>>  target/riscv/cpu_helper.c                         | 2 +-
>>  target/unicore32/helper.c                         | 2 +-
>>  target/xtensa/translate.c                         | 2 +-
>>  target/xtensa/xtensa-semi.c                       | 2 +-
>>  Kconfig                                           | 1 +
>>  MAINTAINERS                                       | 4 ++--
>>  hw/Kconfig                                        | 1 -
>>  hw/meson.build                                    | 1 -
>>  {hw/semihosting => semihosting}/Kconfig           | 0
>>  {hw/semihosting => semihosting}/meson.build       | 0
>>  35 files changed, 35 insertions(+), 35 deletions(-)
>>  rename include/{hw => }/semihosting/console.h (100%)
>>  rename include/{hw => }/semihosting/semihost.h (100%)
>>  rename {hw/semihosting => semihosting}/common-semi.h (100%)
>>  rename {hw/semihosting => semihosting}/arm-compat-semi.c (99%)
>>  rename {hw/semihosting => semihosting}/config.c (99%)
>>  rename {hw/semihosting => semihosting}/console.c (98%)
>>  rename {hw/semihosting => semihosting}/Kconfig (100%)
>>  rename {hw/semihosting => semihosting}/meson.build (100%)
>>
> 
>