Re: [RFC v2 07/24] target/arm: move physical address translation to new modules

[Claudio Fontana]

On 3/1/21 7:49 PM, Richard Henderson wrote:
> On 3/1/21 8:49 AM, Claudio Fontana wrote:
>> --- a/target/arm/internals.h
>> +++ b/target/arm/internals.h
>> @@ -1023,9 +1023,6 @@ typedef struct ARMVAParameters {
>>       bool using64k   : 1;
>>   } ARMVAParameters;
>>   
>> -ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va,
>> -                                   ARMMMUIdx mmu_idx, bool data);
>> -
> 
> Moving aa64_va_parameters away from its struct return is not good.  Either 
> move 
> them both or not at all.

Good point, will take a look at both options.
> 
> The collection of stuff you've split out into get-phys-addr.h is pretty 
> random. 
>   Let's just leave it all in internals.h for now.  We can make a more 
> reasoned 
> decision vs all of the vma and regime related functions.
> 
> 
> r~
> 

The goal here was to make get_phys_addr accessible from KVM too.

get_phys_addr requires the va_parameters family of functions.

Lets see..

Thanks,

C