[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3 09/10] cadence_gem: switch to use qemu_receive_packet() fo
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH V3 09/10] cadence_gem: switch to use qemu_receive_packet() for loopback |
Date: |
Tue, 2 Mar 2021 07:59:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 3/2/21 6:54 AM, Jason Wang wrote:
> From: Alexander Bulekov <alxndr@bu.edu>
>
> This patch switches to use qemu_receive_packet() which can detect
> reentrancy and return early.
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> hw/net/cadence_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index 7a534691f1..6032395388 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -1275,7 +1275,7 @@ static void gem_transmit(CadenceGEMState *s)
> /* Send the packet somewhere */
> if (s->phy_loop || (s->regs[GEM_NWCTRL] &
> GEM_NWCTRL_LOCALLOOP)) {
> - gem_receive(qemu_get_queue(s->nic), s->tx_packet,
> + qemu_receive_packet(qemu_get_queue(s->nic), s->tx_packet,
> total_bytes);
Indent now off, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> } else {
> qemu_send_packet(qemu_get_queue(s->nic), s->tx_packet,
>
- [PATCH V3 05/10] sungem: switch to use qemu_receive_packet() for loopback, (continued)
- [PATCH V3 05/10] sungem: switch to use qemu_receive_packet() for loopback, Jason Wang, 2021/03/02
- [PATCH V3 06/10] tx_pkt: switch to use qemu_receive_packet_iov() for loopback, Jason Wang, 2021/03/02
- [PATCH V3 07/10] rtl8139: switch to use qemu_receive_packet() for loopback, Jason Wang, 2021/03/02
- [PATCH V2 7/7] rtl8193: switch to use qemu_receive_packet() for loopback, Jason Wang, 2021/03/02
- [PATCH V3 08/10] pcnet: switch to use qemu_receive_packet() for loopback, Jason Wang, 2021/03/02
- [PATCH V3 09/10] cadence_gem: switch to use qemu_receive_packet() for loopback, Jason Wang, 2021/03/02
- Re: [PATCH V3 09/10] cadence_gem: switch to use qemu_receive_packet() for loopback,
Philippe Mathieu-Daudé <=
- [PATCH V3 10/10] lan9118: switch to use qemu_receive_packet() for loopback, Jason Wang, 2021/03/02