Re: [PATCH v2 05/42] esp: add trace event when receiving a TI command

[Laurent Vivier]

Le 09/02/2021 à 20:29, Mark Cave-Ayland a écrit :
> This enables us to determine whether the command being issued is for a DMA or 
> a
> non-DMA transfer.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/scsi/esp.c        | 1 +
>  hw/scsi/trace-events | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
> index 9427c55d1d..9951472ee6 100644
> --- a/hw/scsi/esp.c
> +++ b/hw/scsi/esp.c
> @@ -698,6 +698,7 @@ void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t 
> val)
>              }
>              break;
>          case CMD_TI:
> +            trace_esp_mem_writeb_cmd_ti(val);
>              handle_ti(s);
>              break;
>          case CMD_ICCS:
> diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events
> index 0e0aa9847d..762849c7b6 100644
> --- a/hw/scsi/trace-events
> +++ b/hw/scsi/trace-events
> @@ -189,6 +189,7 @@ esp_mem_writeb_cmd_selatn(uint32_t val) "Select with ATN 
> (0x%2.2x)"
>  esp_mem_writeb_cmd_selatns(uint32_t val) "Select with ATN & stop (0x%2.2x)"
>  esp_mem_writeb_cmd_ensel(uint32_t val) "Enable selection (0x%2.2x)"
>  esp_mem_writeb_cmd_dissel(uint32_t val) "Disable selection (0x%2.2x)"
> +esp_mem_writeb_cmd_ti(uint32_t val) "Transfer Information (0x%2.2x)"
>  
>  # esp-pci.c
>  esp_pci_error_invalid_dma_direction(void) "invalid DMA transfer direction"
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>