Re: [PATCH 0/1] Add support for AMD new-style boot mechanism.

[no-reply]

Patchew URL: 
20210301161432.22554-1-danny.milo@datacom.wien/">https://patchew.org/QEMU/20210301161432.22554-1-danny.milo@datacom.wien/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210301161432.22554-1-danny.milo@datacom.wien
Subject: [PATCH 0/1] Add support for AMD new-style boot mechanism.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210301161432.22554-1-danny.milo@datacom.wien -> 
patchew/20210301161432.22554-1-danny.milo@datacom.wien
Switched to a new branch 'test'
aa53a74 i386: Add support for AMD new-style boot mechanism.

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#27: FILE: hw/core/generic-loader.c:56:
+            if (cc->set_csbase)
[...]

WARNING: line over 80 characters
#45: FILE: hw/core/generic-loader.c:185:
+    DEFINE_PROP_UINT64("csbaseaddr", GenericLoaderState, csbaseaddr, 
0xffff0000),

total: 1 errors, 1 warnings, 60 lines checked

Commit aa53a7429c8b (i386: Add support for AMD new-style boot mechanism.) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210301161432.22554-1-danny.milo@datacom.wien/testing.checkpatch/?type=message">http://patchew.org/logs/20210301161432.22554-1-danny.milo@datacom.wien/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com