Re: [PULL 27/29] vl: deprecate -writeconfig

[Markus Armbruster]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 01/03/21 09:00, Markus Armbruster wrote:
>>> +                    warn_report("-writeconfig is deprecated.  It will go 
>>> away in QEMU 6.2 with no replacement");
>>>                       if (strcmp(optarg, "-") == 0) {
>>>                           fp = stdout;
>>>                       } else {
>>
>> Forgot to tweak the warning to "-writeconfig is deprecated and will go
>> away without a replacement"?
>
> Didn't really forget; being pretty sure that there's no usage in the
> wild and having good reasons to remove the code, giving a firm removal 
> date should encourage people to speak up sooner rather than later.

Second thoughts after agreeing to change something are okay.  Keeping
them for yourself not so much, because it deprives your reviewers of a
chance to raise further points.

In this case, the point I didn't make because I wanted to reach
agreement on contents before nitpicking form: you're not using
warn_report() the way it wants to be used:

    /*
     * Print a warning message to current monitor if we have one, else to 
stderr.
     * Format arguments like sprintf(). The resulting message should be a
---> * single phrase, with no newline or trailing punctuation.
     * Prepend the current location and append a newline.
     */
    void warn_report(const char *fmt, ...)

Please tidy up.