Re: [PATCH] multiprocess: move feature to meson_options.txt

[Stefan Hajnoczi]

On Fri, Feb 26, 2021 at 09:50:59AM +0100, Philippe Mathieu-Daudé wrote:
> On 2/26/21 8:48 AM, Paolo Bonzini wrote:
> > On 26/02/21 00:16, Philippe Mathieu-Daudé wrote:
> >>> I personally don’t have any preference for the name.
> >> Great.
> >>
> >> So with the summary/description updated as:
> >>
> >> summary_info += {'Multiprocess QEMU (vfio-user device backends)':
> >> multiprocess_allowed}
> >>
> >> option('multiprocess', type: 'feature', value: 'auto',
> >>         description: 'Multiprocess QEMU (vfio-user device backends)
> >> support')
> >>
> >> Reviewed-by: Philippe Mathieu-Daudé<philmd@redhat.com>
> >>
> > 
> > It's not yet vfio-user.  For now I can put "out of process device
> > emulation";
> 
> OK.
> 
> > however, if the protocol is going to change, I wonder if it
> > should be disabled by default.
> 
> Sounds safer indeed. We need to add --enable-multiprocess in CI to
> keep testing the feature.

Package maintainers tend to disable optional features explicitly, while
developers and CIs may not notice new features that are disabled by
default.

In the interest of preventing bitrot and catching failures early (before
CI!), I suggest leaving it enabled for maximum build coverage.

Stefan

signature.asc
Description: PGP signature