Re: [PATCH 08/25] hmp: replace "O" parser with keyval

[Paolo Bonzini]

On 01/03/21 11:14, Markus Armbruster wrote:
> There is no reason to reject those IDs other than spoiling the fun we're
> having with setting traps for our users.
>
> Since QOM is treating '/' specially in paths, and uses IDs as path
> components, it should reject '/' in IDs.  Same reasoning as for file
> names.

I agree; however I don't think it buys anything to do that in HMP rather 
than further down the call chain, because in the end there are other 
ways to get "anti-social" ids than HMP or the command line.  I commented 
on Kevin's object-add series about this issue.

Paolo

> We already restrict IDs to "letters, digits, '-', '.', '_', starting
> with a letter" in several places, including QemuOpts.  We should do that
> more, not less.
>
> Permitting arbitrary IDs buys us nothing but trouble.