[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/10] iotests/129: Limit mirror job's buffer size
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH v3 08/10] iotests/129: Limit mirror job's buffer size |
Date: |
Fri, 15 Jan 2021 11:49:16 -0300 |
On Thu, Jan 14, 2021 at 2:37 PM Max Reitz <mreitz@redhat.com> wrote:
>
> Issuing 'stop' on the VM drains all nodes. If the mirror job has many
> large requests in flight, this may lead to significant I/O that looks a
> bit like 'stop' would make the job try to complete (which is what 129
> should verify not to happen).
>
> We can limit the I/O in flight by limiting the buffer size, so mirror
> will make very little progress during the 'stop' drain.
>
> (We do not need to do anything about commit, which has a buffer size of
> 512 kB by default; or backup, which goes cluster by cluster. Once we
> have asynchronous requests for backup, that will change, but then we can
> fine-tune the backup job to only perform a single request on a very
> small chunk, too.)
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/129 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
- Re: [PATCH v3 04/10] iotests/129: Remove test images in tearDown(), (continued)
- [PATCH v3 05/10] iotests/129: Do not check @busy, Max Reitz, 2021/01/14
- [PATCH v3 06/10] iotests/129: Use throttle node, Max Reitz, 2021/01/14
- [PATCH v3 08/10] iotests/129: Limit mirror job's buffer size, Max Reitz, 2021/01/14
- Re: [PATCH v3 08/10] iotests/129: Limit mirror job's buffer size,
Willian Rampazzo <=
- [PATCH v3 07/10] iotests/129: Actually test a commit job, Max Reitz, 2021/01/14
- [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints, Max Reitz, 2021/01/14
- Re: [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints, Vladimir Sementsov-Ogievskiy, 2021/01/15
[PATCH v3 10/10] iotests/300: Clean up pylint and mypy complaints, Max Reitz, 2021/01/14
[PATCH v3 11/10] iotests: add flake8 linter, Vladimir Sementsov-Ogievskiy, 2021/01/15