[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 01/13] qemu/atomic: Drop special case for unsupported compiler
From: |
marcandre . lureau |
Subject: |
[PATCH v3 01/13] qemu/atomic: Drop special case for unsupported compiler |
Date: |
Thu, 10 Dec 2020 17:47:40 +0400 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Since commit efc6c070aca ("configure: Add a test for the
minimum compiler version") the minimum compiler version
required for GCC is 4.8, which has the GCC BZ#36793 bug fixed.
We can safely remove the special case introduced in commit
a281ebc11a6 ("virtio: add missing mb() on notification").
With clang 3.4, __ATOMIC_RELAXED is defined, so the chunk to
remove (which is x86-specific), isn't reached either.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
include/qemu/atomic.h | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h
index c1d211a351..8f4b3a80fb 100644
--- a/include/qemu/atomic.h
+++ b/include/qemu/atomic.h
@@ -241,23 +241,6 @@
#else /* __ATOMIC_RELAXED */
-/*
- * We use GCC builtin if it's available, as that can use mfence on
- * 32-bit as well, e.g. if built with -march=pentium-m. However, on
- * i386 the spec is buggy, and the implementation followed it until
- * 4.3 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36793).
- */
-#if defined(__i386__) || defined(__x86_64__)
-#if !QEMU_GNUC_PREREQ(4, 4)
-#if defined __x86_64__
-#define smp_mb() ({ asm volatile("mfence" ::: "memory"); (void)0; })
-#else
-#define smp_mb() ({ asm volatile("lock; addl $0,0(%%esp) " ::: "memory");
(void)0; })
-#endif
-#endif
-#endif
-
-
#ifdef __alpha__
#define smp_read_barrier_depends() asm volatile("mb":::"memory")
#endif
--
2.29.0
- [PATCH v3 00/13] Remove GCC < 4.8 checks, marcandre . lureau, 2020/12/10
- [PATCH v3 01/13] qemu/atomic: Drop special case for unsupported compiler,
marcandre . lureau <=
- [PATCH v3 02/13] accel/tcg: Remove special case for GCC < 4.6, marcandre . lureau, 2020/12/10
- [PATCH v3 03/13] compiler.h: remove GCC < 3 __builtin_expect fallback, marcandre . lureau, 2020/12/10
- [PATCH v3 04/13] qemu-plugin.h: remove GCC < 4, marcandre . lureau, 2020/12/10
- [PATCH v3 05/13] tests: remove GCC < 4 fallbacks, marcandre . lureau, 2020/12/10
- [PATCH v3 06/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON, marcandre . lureau, 2020/12/10