[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 6/7] block: bdrv_child_set_perm() drop redundant parameters.
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v2 6/7] block: bdrv_child_set_perm() drop redundant parameters. |
Date: |
Fri, 6 Nov 2020 15:42:40 +0300 |
We must set the permission used for _check_. Assert that we have
backup and drop extra arguments.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/block.c b/block.c
index b61d20252f..b44db05d14 100644
--- a/block.c
+++ b/block.c
@@ -1897,7 +1897,7 @@ static int bdrv_child_check_perm(BdrvChild *c,
BlockReopenQueue *q,
GSList *ignore_children,
bool *tighten_restrictions, Error **errp);
static void bdrv_child_abort_perm_update(BdrvChild *c);
-static void bdrv_child_set_perm(BdrvChild *c, uint64_t perm, uint64_t shared);
+static void bdrv_child_set_perm(BdrvChild *c);
typedef struct BlockReopenQueueEntry {
bool prepared;
@@ -2131,11 +2131,7 @@ static void bdrv_set_perm(BlockDriverState *bs)
/* Update all children */
QLIST_FOREACH(c, &bs->children, next) {
- uint64_t cur_perm, cur_shared;
- bdrv_child_perm(bs, c->bs, c, c->role, NULL,
- cumulative_perms, cumulative_shared_perms,
- &cur_perm, &cur_shared);
- bdrv_child_set_perm(c, cur_perm, cur_shared);
+ bdrv_child_set_perm(c);
}
}
@@ -2298,13 +2294,10 @@ static int bdrv_child_check_perm(BdrvChild *c,
BlockReopenQueue *q,
return 0;
}
-static void bdrv_child_set_perm(BdrvChild *c, uint64_t perm, uint64_t shared)
+static void bdrv_child_set_perm(BdrvChild *c)
{
c->has_backup_perm = false;
- c->perm = perm;
- c->shared_perm = shared;
-
bdrv_set_perm(c->bs);
}
@@ -2362,7 +2355,7 @@ int bdrv_child_try_set_perm(BdrvChild *c, uint64_t perm,
uint64_t shared,
return ret;
}
- bdrv_child_set_perm(c, perm, shared);
+ bdrv_child_set_perm(c);
return 0;
}
--
2.21.3
- [PATCH v2 3/7] block: make bdrv_drop_intermediate() less wrong, (continued)
- [PATCH v2 1/7] block: add forgotten bdrv_abort_perm_update() to bdrv_co_invalidate_cache(), Vladimir Sementsov-Ogievskiy, 2020/11/06
- [PATCH v2 2/7] block: add bdrv_replace_node_common(), Vladimir Sementsov-Ogievskiy, 2020/11/06
- [PATCH v2 6/7] block: bdrv_child_set_perm() drop redundant parameters.,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v2 5/7] block: bdrv_set_perm() drop redundant parameters., Vladimir Sementsov-Ogievskiy, 2020/11/06
- [PATCH v2 7/7] block: drop tighten_restrictions, Vladimir Sementsov-Ogievskiy, 2020/11/06
- Re: [PATCH v2 0/7] block: permission update fix & refactor, Max Reitz, 2020/11/09