[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/unicore32/translate: Add missing fallthrough annotati
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] target/unicore32/translate: Add missing fallthrough annotations |
|
Date: |
Fri, 30 Oct 2020 11:43:12 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 10/30/20 2:31 AM, Thomas Huth wrote:
> Looking at the way the code is formatted here (there is an empty
> line after break statements, but none where the break is missing),
> the fallthrough is very likely intended here. So add a fallthrough
> comment to make the it compilable with -Werror=implicit-fallthrough.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/unicore32/translate.c | 2 ++
> 1 file changed, 2 insertions(+)
We don't need to guess based on blank lines.
This matches with the instruction set overview at
https://en.wikipedia.org/wiki/Unicore
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~