[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument |
Date: |
Fri, 30 Oct 2020 07:16:43 -0400 |
On Fri, Oct 30, 2020 at 12:00:33PM +0400, Marc-André Lureau wrote:
> On Fri, Oct 30, 2020 at 2:16 AM Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> > Make the code more generic and not specific to TYPE_DEVICE.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> >
>
> What about dropping _qdev from the function name too?
I have a series that deletes the function completely, but I
decided to leave it outside of this first batch.
>
> Also, I am not sure it's a well designed function.. I would rather have 3
> different helper functions than dispatching with an errno... Might be worth
> a TODO note :)
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Thanks!
--
Eduardo
- Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, (continued)
- [PATCH 11/36] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/10/29
- [PATCH 13/36] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/10/29
- [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/10/29
- [PATCH 15/36] qdev: Make PropertyInfo.create return ObjectProperty*, Eduardo Habkost, 2020/10/29
- [PATCH 16/36] qdev: Make qdev_class_add_property() more flexible, Eduardo Habkost, 2020/10/29
- [PATCH 17/36] qdev: Separate generic and device-specific property registration, Eduardo Habkost, 2020/10/29
- [PATCH 19/36] qdev: Move array property creation/registration to separate functions, Eduardo Habkost, 2020/10/29